-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fix code examples error in useLayoutEffect and useMemo documentation #8062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…specify source files
Hi @armedi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes missing file path specifications in code block declarations for React documentation examples. The changes ensure that code examples in the useLayoutEffect
and useMemo
documentation pages properly specify their file paths, which is necessary for the documentation's code sandbox functionality to work correctly.
- Adds missing file path specifications to code block declarations
- Updates four code blocks across two documentation files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/content/reference/react/useMemo.md | Adds file path specification to TodoList.js code example |
src/content/reference/react/useLayoutEffect.md | Adds file path specifications to three code examples (Tooltip.js and App.js) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fixes #8059
Not only the useLayoutEffect page as reported in the above issue, the useMemo page is also affected